diff --git a/memory/2026-02-25-predictive-memory-scorer-spec-review-feedback-inte.md b/memory/2026-02-25-predictive-memory-scorer-spec-review-feedback-inte.md new file mode 100644 index 000000000..26860d494 --- /dev/null +++ b/memory/2026-02-25-predictive-memory-scorer-spec-review-feedback-inte.md @@ -0,0 +1,19 @@ +# 2026-02-25 Session Notes + +## Predictive Memory Scorer Spec Review & Feedback Integration + +Nicholai received detailed external code review feedback on the predictive memory scorer specification (`docs/wip/predictive-memory-scorer.md`). The reviewer provided high-level validation of the overall architecture—calling it "exceptionally well-thought-out" and praising the North Star vision ("difference between a tool that remembers and a mind that persists")—while identifying five concrete technical refinements. + +### Feedback Highlights + +The reviewer validated three core design strengths: (1) Dynamic baseline weighting via RRF with EMA success rate ensures graceful degradation; (2) Zero-dependency Rust sidecar keeps binary size negligible and inference sub-millisecond; (3) Outcome-driven labels via continuity scorer avoids hand-labeling overhead. + +### Five Technical Refinements Identified + +1. **HashTrick bucket count**: Bump from 4,096 to 16,384 to reduce collisions in code-heavy memories (still ~1.1M parameters, fits L2 cache) +2. **Listwise loss temperature**: Use T < 1.0 to sharpen soft label distributions; flat P_true from continuity scorer soft labels requires aggressive sharpening +3. **Negative sample filtering**: Apply cosine similarity filter before assigning strict 0.0 labels; prevents training model to replicate baseline mistakes +4. **Drift reset strategy**: Use replay buffer (80% recent + 20% historical by continuity score) instead of 2x learning rate to avoid catastrophic forgetting +5. **RRF constant k**: Drop from 60 to 10–15 for ~50 candidate memories; k=60 compresses rank variance when candidate list is small + +All five recommendations are sound and likely to be incorporated into the specification. \ No newline at end of file diff --git a/memory/memories.db-shm b/memory/memories.db-shm index 18d69c374..270304321 100644 Binary files a/memory/memories.db-shm and b/memory/memories.db-shm differ diff --git a/memory/memories.db-wal b/memory/memories.db-wal index 4b164a315..c10ae0de8 100644 Binary files a/memory/memories.db-wal and b/memory/memories.db-wal differ