jake/compassmock
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(auth): noopener returns null popup reference

Browse Source 
window.open with noopener returns null, so the subsequent
location.href assignment was a no-op. Open without noopener,
then null out opener manually before navigating.
This commit is contained in:
Nicholai Vogel 2026-02-16 23:51:07 -07:00
parent 7d7eb72ea8
commit 0198898979
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/settings/ai-model-tab.tsx
View File

@ -318,11 +318,15 @@ function ProviderConfigSection({
const handleOAuthConnect = async (): Promise<void> => { const handleOAuthConnect = async (): Promise<void> => {
// Open window immediately in the click handler to avoid // Open window immediately in the click handler to avoid
// popup blockers (async gap kills the user gesture) // popup blockers (async gap kills the user gesture).
const popup = window.open("about:blank", "_blank", "noopener") // Can't use noopener here — it makes window.open return null.
const popup = window.open("about:blank", "_blank")
const { verifier, challenge } = await generatePKCE() const { verifier, challenge } = await generatePKCE()
const url = buildAuthUrl(challenge) const url = buildAuthUrl(challenge)
if (popup) popup.location.href = url if (popup) {
popup.opener = null
popup.location.href = url
}
setOAuth({ step: "connecting", verifier }) setOAuth({ step: "connecting", verifier })
} }