jake/compassmock
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(auth): open OAuth popup before async PKCE

Browse Source 
Browsers block window.open after an await because the user
gesture is lost. Open a blank tab synchronously first, then
set the URL after PKCE generation completes.
This commit is contained in:
Nicholai Vogel 2026-02-16 23:45:26 -07:00
parent c53f3a5fac
commit 7d7eb72ea8
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/settings/ai-model-tab.tsx
View File

@ -317,10 +317,13 @@ function ProviderConfigSection({
} }
const handleOAuthConnect = async (): Promise<void> => { const handleOAuthConnect = async (): Promise<void> => {
// Open window immediately in the click handler to avoid
// popup blockers (async gap kills the user gesture)
const popup = window.open("about:blank", "_blank", "noopener")
const { verifier, challenge } = await generatePKCE() const { verifier, challenge } = await generatePKCE()
const url = buildAuthUrl(challenge) const url = buildAuthUrl(challenge)
if (popup) popup.location.href = url
setOAuth({ step: "connecting", verifier }) setOAuth({ step: "connecting", verifier })
window.open(url, "_blank", "noopener")
} }
const handleOAuthSubmit = async (): Promise<void> => { const handleOAuthSubmit = async (): Promise<void> => {