From 93a790833e7e0dbc003f6bfcaf787e09d10b6781 Mon Sep 17 00:00:00 2001 From: Deborah Mangan Date: Mon, 3 Nov 2025 11:55:59 +1000 Subject: [PATCH] fix: Address AI code reviewer feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix branding references (VoiceLink → VoiceInk) in documentation - Correct keyboard shortcut documentation to Cmd+Shift+/ for proper Cmd+? - Remove force unwrap in webhook example code Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> --- IMPLEMENTATION_SUMMARY.md | 4 ++-- QOL_IMPROVEMENTS_CHANGELOG.md | 2 +- QUALITY_OF_LIFE_IMPROVEMENTS.md | 6 +++++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/IMPLEMENTATION_SUMMARY.md b/IMPLEMENTATION_SUMMARY.md index 2773da6..ab9447d 100644 --- a/IMPLEMENTATION_SUMMARY.md +++ b/IMPLEMENTATION_SUMMARY.md @@ -7,7 +7,7 @@ ## What Was Implemented -We successfully implemented **5 critical quality of life improvements** for VoiceLink Community: +We successfully implemented **5 critical quality of life improvements** for VoiceInk: ### ✅ 1. Recording Duration Indicator - Real-time timer showing MM:SS format during recording @@ -381,4 +381,4 @@ Before merging/deploying: **Last Updated:** November 3, 2025 **Implemented By:** AI Assistant via Factory -**Maintained By:** VoiceLink Community +**Maintained By:** VoiceInk Community diff --git a/QOL_IMPROVEMENTS_CHANGELOG.md b/QOL_IMPROVEMENTS_CHANGELOG.md index 0f1ae47..d3921a3 100644 --- a/QOL_IMPROVEMENTS_CHANGELOG.md +++ b/QOL_IMPROVEMENTS_CHANGELOG.md @@ -239,7 +239,7 @@ struct KeyboardShortcutCheatSheet: View { Button("Keyboard Shortcuts") { NotificationCenter.default.post(name: .showShortcutCheatSheet, object: nil) } - .keyboardShortcut("/", modifiers: .command) + .keyboardShortcut("/", modifiers: [.command, .shift]) } } ``` diff --git a/QUALITY_OF_LIFE_IMPROVEMENTS.md b/QUALITY_OF_LIFE_IMPROVEMENTS.md index 4f88e06..7f86d55 100644 --- a/QUALITY_OF_LIFE_IMPROVEMENTS.md +++ b/QUALITY_OF_LIFE_IMPROVEMENTS.md @@ -823,7 +823,11 @@ func sendToWebhook(_ transcription: Transcription) async throws { "duration": transcription.duration ] - var request = URLRequest(url: URL(string: settings.url)!) + guard let url = URL(string: settings.url) else { + throw WebhookError.invalidURL + } + + var request = URLRequest(url: url) request.httpMethod = "POST" request.httpBody = try JSONSerialization.data(withJSONObject: payload)