.agents/memory/2026-03-04-pr-review-session-start.md

15 lines
1.1 KiB
Markdown

# 2026-03-04 Session Notes
## PR Review Session Start
Nicholai requested a review of PR #111 from ddasgupta4 titled "fix(constellation): join vec_embeddings to resolve missing vector column crash". The assistant located and began gathering details on the PR.
## PR #111 Overview
The PR fixes a critical bug in the Constellation tab of the Signet dashboard. The tab was permanently stuck on "Computing layout..." and the `/api/embeddings/health` endpoint was returning 500 Internal Server Error.
Root cause: The UMAP projection query in `umap-projection.ts` was attempting to select `e.vector` from the `embeddings` table, but this column does not exist. Vector data is actually stored in the `vec_embeddings` sqlite-vec virtual table under the `embedding` column.
The fix adds an `INNER JOIN vec_embeddings v ON v.id = e.id` clause and changes the selection to `v.embedding AS vector`. Additionally, the `blobToVector` function was updated to accept both `Uint8Array` and `Buffer` types.
The PR contains 9 additions and addresses a critical path issue affecting the dashboard's main constellation visualization feature.